Open
Conversation
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
…ngost-0.16 Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
…ngost-0.16 Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
Signed-off-by: Mikal Villa <mikalv@mikalv.net>
|
As a note regarding this and your other PR (and I know both have been open for a long time), any changes/PRs should be atomic and small, this PR is just too big for anyone to review (even github won’t show all the changes) plus the fact that unit tests doesn’t work and there is no way of knowing the stability of the changes means they will never get merged Instead you should split functional additions, file rebranding and documentation changes on their own smaller PRs Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems better to upgrade source while at it. Then we can also get rid of some old trash :)